Review checklists

What to check when you review a change in an area where knowing the domain is not enough, and where the evidence comes from.

A review states what it verified and how. These checklists name the sources that settle each question in this repository, so a review rests on the code and its tests rather than on what the reviewer remembers about Airflow, Kubernetes or the docs.

They complement the rules: the root AGENTS.md and the AGENTS.md of the directory a change touches say what a change must do, and the recipes say how to make it. A release candidate has its own list of reviews in AGENTS.md section 1.


Review checklist: Airflow compatibility

Check an Airflow compatibility claim against the parser, the authoring schema and the domain types, not against what Airflow does.

Review checklist: Kubernetes behavior

Separate what the code and its tests confirm from what only a real cluster can show, and say which one each claim rests on.

Review checklist: docs

Check that a page sits in the right kind of section, starts from the reader’s task, uses the current names, and passes the docs gates.

Review checklist: developer experience

Review a new setting, flag, value, command or error from the side of the person who meets it, starting with what happens when they set nothing.